Indicate how to skip rules on failures #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/prevent-complaints
branch
from
8c2b712
to
3fdaa50
Compare
ssbarnea
added
the
feedback-needed
This was referenced Aug 18, 2020
Make it easier for users to disable rules that they do not find fit by displaying a sample configuration file after the execution.
ssbarnea
force-pushed
the
fix/prevent-complaints
branch
from
3fdaa50
to
c917955
Compare
btravouillon
approved these changes
Aug 20, 2020
acozine
reviewed
Aug 20, 2020
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
awcrosby
approved these changes
Aug 20, 2020
ssbarnea
removed
the
feedback-needed
This was referenced Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier for users to disable rules that they do not find fit by displaying a sample configuration file after the execution.
Note that his change adds rich library as a dependency as we also plan to use it for improve terminal output in other areas like rule listing or more detailed explanation about why a rule was added (#936). Library is MIT and under good maintenance.