Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pbr dependency on Fedora and EL packaging #140

Closed
dmsimard opened this issue Jun 1, 2020 · 7 comments
Closed

Missing pbr dependency on Fedora and EL packaging #140

dmsimard opened this issue Jun 1, 2020 · 7 comments
Labels
packaging Related to the packaging

Comments

@dmsimard
Copy link
Contributor

dmsimard commented Jun 1, 2020

What component is this about ?

Packaging for ARA on Fedora and EL

What is happening ?

pbr is listed as a buildrequires but not as a requires in the packaging: https://src.fedoraproject.org/rpms/ara/blob/f32/f/ara.spec

This can lead to runtime exceptions on missing pbr if it has not been installed through other dependencies.

What should be happening ?

pbr is a dependency and should be required.

@dmsimard dmsimard added the packaging Related to the packaging label Jun 1, 2020
@dmsimard
Copy link
Contributor Author

dmsimard commented Jun 1, 2020

@arrfab ^ FYI, are you building from the epel8 branch ? I will take care of this while bumping the packaging for the new 1.4.1 release.

@arrfab
Copy link
Contributor

arrfab commented Jun 1, 2020

Yes, I wanted to open a PR to add it, as myself I discovered that it was needed at runtime.

@dmsimard
Copy link
Contributor Author

dmsimard commented Jun 1, 2020

Pull requests for 1.4.1 and adding pbr:

Haven't done master yet, I think it's failing to build because of the requires on python3-ara which hasn't been built yet.
The intent is to have "aliases" for ara -> python3-ara and ara-server for python3-ara-server in order to be able to do dnf install ara ara-server but I probably screwed that up.

@dmsimard
Copy link
Contributor Author

dmsimard commented Jun 1, 2020

f32, f31 and epel8 PRs are merged and updates submitted to bodhi.

@arrfab
Copy link
Contributor

arrfab commented Jun 2, 2020

Good, submitted a build that I'll tag to testing too for CentOS (https://cbs.centos.org/koji/taskinfo?taskID=1329140) and if that works, I'll tag to -release and it will be signed and pushed to mirrors

@arrfab
Copy link
Contributor

arrfab commented Jun 2, 2020

Correctly triggering now the python3-pbr install, so for centos configmanagement, I'll tag it to -release :

yum update  --enablerepo=centos-ansible-29-testing
Last metadata expiration check: 0:00:17 ago on Tue 02 Jun 2020 07:00:46 UTC.
Dependencies resolved.
=======================================================================================================================
 Package                  Architecture        Version                     Repository                              Size
=======================================================================================================================
Upgrading:
 ara                      noarch              1.4.1-1.el8                 centos-ansible-29-testing               22 k
 python3-ara              noarch              1.4.1-1.el8                 centos-ansible-29-testing              391 k
Installing dependencies:
 python3-pbr              noarch              5.4.3-2.el8                 centos-ansible-29                       90 k

@dmsimard
Copy link
Contributor Author

dmsimard commented Jun 2, 2020

@arrfab amazing! Thanks for taking care of this so quickly 🎉

I guess I'll close this issue now.

@dmsimard dmsimard closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Related to the packaging
Projects
None yet
Development

No branches or pull requests

2 participants