Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write integration tests for new ARA_RECORD_ settings #506

Closed
dmsimard opened this issue Sep 3, 2023 · 0 comments · Fixed by #507
Closed

Write integration tests for new ARA_RECORD_ settings #506

dmsimard opened this issue Sep 3, 2023 · 0 comments · Fixed by #507
Milestone

Comments

@dmsimard
Copy link
Contributor

dmsimard commented Sep 3, 2023

What is the idea ?

The callback has grown three new settings thanks to the contributions in #458 and #496:

  • ARA_RECORD_USER_NAME (to manually override the recorded user for a playbook)
  • ARA_RECORD_CONTROLLER_NAME (to manually override the recorded controller for a playbook)
  • ARA_RECORD_TASK_CONTENT (to prevent ara from recording task content)

Before releasing 1.7.0, there needs to be a minimum of testing coverage for them.

It might end up looking similar to what we do when testing controller hostnames:

ara/tests/basic.yaml

Lines 191 to 194 in d736213

- name: Run lookup integration tests
environment:
ARA_LOCALHOST_AS_HOSTNAME: "{{ ara_localhost_as_hostname | default(true) }}"
command: "ansible-playbook -vvv {{ _test_root }}/lookups.yaml"

And then, in something like the lookups test playbook, we'd add tests to validate that we have indeed the expected name, hostname and that we don't have the task content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant