Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for setting EC2 instance profile #164

Merged
merged 2 commits into from Jun 9, 2023
Merged

Allow for setting EC2 instance profile #164

merged 2 commits into from Jun 9, 2023

Conversation

Thomas-McKanna
Copy link
Contributor

This is a small change, but I think it would be useful for people to be able to set an instance profile if the EC2 instance needs access to other AWS resources, like S3 buckets.

apatard
apatard requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@apatard apatard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the extra space before the colon in the create.yml change ?
(See lint check)

@Thomas-McKanna
Copy link
Contributor Author

Yes @apatard I will get that change pushed shortly

@Thomas-McKanna
Copy link
Contributor Author

Change has been made

@apatard apatard added enhancement New feature or request ec2 Amazon EC2 labels Jun 9, 2023
@apatard
Copy link
Member

apatard commented Jun 9, 2023

Change has been made

Thanks.

@apatard apatard merged commit 0e09ebe into ansible-community:main Jun 9, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apatard apatard apatard approved these changes

Assignees
No one assigned
Labels
ec2 Amazon EC2 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Thomas-McKanna @apatard @Thomas-McKanna-Test