Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挅 vagrant plugin welcomes new contributors and maintainers #63

Closed
ssbarnea opened this issue Jan 14, 2020 · 18 comments
Closed

馃挅 vagrant plugin welcomes new contributors and maintainers #63

ssbarnea opened this issue Jan 14, 2020 · 18 comments
Labels
help wanted Extra attention is needed

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Jan 14, 2020

I am unable to maintain this driver as I am not using it, so I am looking for maintainers.

I can keep providing support for integration with molecule itself but not around vagrant bits.

I would work noting that the top priority would be to setup CI jobs.

@ssbarnea ssbarnea added the help wanted Extra attention is needed label Jan 14, 2020
@hswong3i
Copy link
Contributor

@ssbarnea could i give a hand for this driver?

I am now using it for all of my Ansible roles, in Travis CI + Libvirt + KVM, see:

@jonashackt
Copy link

I also would say CI jobs would be a show stopper for anyone trying to help with this (I also think about helping out...). I was already loosely involved in ansible/molecule#1600 (comment) and tried to create an example pipeline using a free CI platform to be able to create VagrantBoxes (with VirtualBox) in https://github.com/jonashackt/vagrant-ansible-on-appveyor - but sadly failed back then.

Now with the Molecule v3 release I stepped back into the game, since there was some development at AppVeyor since then and there seems to be a possiblity right now, to use Vagrant with them. Therefor I filed an issue https://help.appveyor.com/discussions/questions/46774-nested-virtualization-needed-for-opensource-projects-vt-x-is-not-available-verr_vmx_no_vmx - let's see, if they will help here. Will come back, if there's any progress. I don't really see other free options aside from AppVeyor, everything else needs to be payed for...

@jonashackt
Copy link

Ah @hswong3i I misread your solution, sounds great. Will look into it.

@jonashackt
Copy link

Wow @hswong3i this really works... Vagrant + libvrt Plugin + libvrt + KVM on Travis... nice - full example here https://github.com/jonashackt/vagrant-travisci-libvrt. So this could be also a way of creating the CI jobs for Molecule 馃憤

@sio
Copy link

sio commented Feb 24, 2020

@jonashackt, CirrusCI also offers free virtualization: https://cirrus-ci.org/guide/linux/#kvm-enabled-privileged-containers

I'm testing my Ansible roles there.

@ssbarnea
Copy link
Member Author

I welcome anyone to join this. You will need to document for each CI how to setup Vagrant and assure that it is working. Installing vagrant does not mean it will be able to start a VM.

I am currently working on fixing this for Zuul CI, which is what we use for testing.

@ssbarnea
Copy link
Member Author

ssbarnea commented Feb 25, 2020

CI is working, feel free to start creating PR now, or reviewing existing ones.

Be sure you use the review option when doing reviews, when approved we should see a gray "v" check. Mentioning because the review option is well hidden in the UI.

@hswong3i
Copy link
Contributor

hswong3i commented Feb 25, 2020

@ssbarnea thank you very much and confirmed after ansible-community/molecule-vagrant#10 get committed with ansible-community/molecule-vagrant@78582f9, no more hacky dirty workaround is required for:

  • molecule/*/create.yml
  • molecule/*/prepare.yml
  • molecule/*/destroy.yml
  • molecule/*/library/molecule_vagrant.py

My complete example for migrate from Molecule 2.22.0 to 3.0.2 goes here:

Enjoy ;-)

@stdevel
Copy link

stdevel commented Feb 25, 2020

Thank you so much, @hswong3i - I'm finally able to use Molecule with Vagrant again! 馃帀

@ssbarnea ssbarnea pinned this issue Feb 25, 2020
@hswong3i
Copy link
Contributor

@ssbarnea thank you very much for v0.2, example above updated, too ;-)

@hswong3i
Copy link
Contributor

@jonashackt For Travis CI + Vagrant + VirtualBox we may need --nested-hw-virt, which natively enabled for Libvirt + KVM

See https://www.virtualbox.org/manual/ch09.html#nested-virt

@ssbarnea ssbarnea changed the title looking for maintainers 馃挅 looking for vagrant maintainers Feb 29, 2020
@apatard
Copy link
Member

apatard commented Mar 2, 2020

I've said it on IRC but it's a good idea to say it here too. If help is still needed/wanted, I can try helping in maintaining the vagrant molecule plugin.

@ssbarnea
Copy link
Member Author

ssbarnea commented Mar 2, 2020

Please watch the project and do reviews on issues or PRs. Even ping me directly here or on irc, after this I will also give you more privileges.

It would also be very useful if you can find a way to fix the vagrant installation on the broken platforms (so we can remove the voting: false)

@rgarrigue
Copy link

Thanks @hswong3i for the example. Wish this could be added in the doc.

@ssbarnea
Copy link
Member Author

I invited few people but I will keep the ticket open. If you want to help, just add a comment here and mention my name. I will send you an invite so you can start doing triage, reviews.

@karcaw
Copy link

karcaw commented Apr 30, 2020

this code is becoming very important to our team and will be for years I believe, so I'll add my name to the list of people that can help

@ssbarnea
Copy link
Member Author

ssbarnea commented May 1, 2020

Done, invited all. If I missed anyone mention me in a comment.

Please watch the project for PRs and review them, only when it gets reviews add the "gate" label to tell CI to merge it. There is not manual merge.

@bbaassssiiee
Copy link
Member

bbaassssiiee commented Jun 4, 2020

@kikitux is this something for you? @ssbarnea

@ssbarnea ssbarnea changed the title 馃挅 looking for vagrant maintainers 馃挅 vagrant plugin welcomes new contributors and maintainers May 12, 2021
@ssbarnea ssbarnea transferred this issue from ansible-community/molecule-vagrant Jan 6, 2023
@ansible-community ansible-community locked and limited conversation to collaborators Nov 14, 2023
@zhan9san zhan9san converted this issue into discussion #203 Nov 14, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
help wanted Extra attention is needed
Projects
Development

No branches or pull requests

9 participants