Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed linters #2802

Merged
merged 1 commit into from Aug 29, 2020
Merged

Fixed linters #2802

merged 1 commit into from Aug 29, 2020

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Aug 29, 2020

Among normal bumping of linters temporary pins down pydocstyle due to recent regression.

Related: PyCQA/pydocstyle#506

Among normal bumping of linters temporary pins down pydocstyle due
to recent regression.

Related: PyCQA/pydocstyle#506
@ssbarnea ssbarnea added the bug label Aug 29, 2020
@ssbarnea ssbarnea changed the title Bumped linters Fixed linters Aug 29, 2020
Copy link
Contributor

@greg-hellings greg-hellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want to pin pydocstyle to a less than, or just exclude the known broken version?

@ssbarnea
Copy link
Member Author

Do you really want to pin pydocstyle to a less than, or just exclude the known broken version?

It did not merge so I have no guarantee that it will be merged before the next tag is added. If it was merged I would have picked for exclusion. Anyway, I am not worried much about this because next bumping of linter would remind me to replace the downpinning.

@ssbarnea ssbarnea merged commit 509d300 into master Aug 29, 2020
@ssbarnea ssbarnea deleted the fix/bumped-linters branch August 29, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants