Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow os_walk to follow symlinks #3026

Merged
merged 1 commit into from Jan 7, 2021

Conversation

ragingpastry
Copy link
Contributor

@ragingpastry ragingpastry commented Jan 6, 2021

Allows the testinfra verifier to follow symlinks in the tests
directory.

This fixes a bug described here:
#3021

Previously, os_walk would not follow symlinks. This would break scenarios where you place tests in a common test directory.

For example the following directory structure:

molecule
├── common
│   └── unit
│       ├── test_ldap.py
│       └── test_zabbix.py
├── default
│   ├── conftest.py
│   ├── converge.yml
│   ├── create.yml
│   ├── Dockerfile.j2
│   ├── INSTALL.rst
│   ├── molecule.yml
│   ├── prepare.yml
│   ├── requirements.yml
│   └── tests
│       ├── conftest.py
└── zabbix-4.4.9
    ├── converge.yml
    ├── create.yml
    ├── Dockerfile.j2
    ├── INSTALL.rst
    ├── molecule.yml
    ├── prepare.yml
    ├── requirements.yml
    └── tests
        ├── conftest.py
        └── unit -> ../../common/unit

When running molecule verify -s zabbix-4.4.9 no tests would be found.

Allows the testinfra verifier to follow symlinks in the tests
directory.

This fixes a bug described here:
ansible#3021
@ssbarnea ssbarnea added the bug label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants