New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple base configs #3029
Conversation
8e32532
to
3a8b399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks legit.
I don't even want to know why you need multiple base configs 🏃♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have a quite complex setup and would probably benefit from this change.
That being said, there is one area that definitely needs improvement in this PR: documenting each base config file's priority. Right now, help text only states that we can use multiple base config files, but it does not specify what happens if two of them contain the same configuration options with different values. Reading through the implementation, the last one wins, but I do not know enough about click to be certain if argument parsing preserves the order of options.
I added one comment about the default value that needs to be resolved before merging.
3a8b399
to
755a0c2
Compare
755a0c2
to
f5b74ba
Compare
@tadeboro The argument parsing preserves the order of options. Regarding the documentation, I tried to improve it but I'm far from being even a medium technical writer so please check if it makes any sense :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lebauce, for your contribution!
Allow specifing the --base-config option multiple times.
The
base-config
option is really useful to avoid duplication but, in a complicated setup,we often end up having multiple
base-config
files with a lot of duplication between these files.PR Type