Make molecule reuse prerun from ansible-lint #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apatard
reviewed
Mar 19, 2021
ssbarnea
force-pushed
the
os/prerun
branch
5 times, most recently
from
48ff10a
to
3fbc320
Compare
ssbarnea
changed the title
ssbarnea
force-pushed
the
os/prerun
branch
8 times, most recently
from
f3ad3b7
to
a763021
Compare
apatard
reviewed
Mar 22, 2021
ssbarnea
force-pushed
the
os/prerun
branch
2 times, most recently
from
2014129
to
aea296c
Compare
ssbarnea
changed the title
tadeboro
approved these changes
Mar 22, 2021
apatard
reviewed
Mar 23, 2021
apatard
reviewed
Mar 23, 2021
|
I've done a quick test. While it doesnt solve my bug, this change make molecule behaves in the same way as ansible-lint, |
ssbarnea
force-pushed
the
os/prerun
branch
4 times, most recently
from
6dab445
to
4ebcf18
Compare
As ansible-lint is able to detect repository layout and run prepare ansible from running it, we rely on its logic in order to assure ansible is able to run properly. This means that dependencies will be installed into .cache folder and that the role import path will be updated to include it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ansible-lint is able to detect repository layout and run prepare ansible from running it, we rely on its logic in order to assure ansible is able to run properly.
This means that dependencies will be installed into .cache folder and that the role import path will be updated to include it.