Change ANSIBLE_LIBRARY PATH processing #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhahaha
reviewed
Jun 3, 2021
cloudnull
force-pushed
the
ansible-library
branch
3 times, most recently
from
3f6fae8
to
7c77c94
Compare
|
This change will not pass the docs checks until #3138 merges. |
cloudnull
force-pushed
the
ansible-library
branch
from
7c77c94
to
33306f6
Compare
tadeboro
approved these changes
Jun 3, 2021
|
@cloudnull Would you be so kind as to rebase your work on top of the main branch and then force push it? This should turn the last red test into a green one (In the log at https://readthedocs.org/projects/molecule/builds/13925451/, I still see the old extension being used). Thank you in advance! |
Done |
When the environment variable ANSIBLE_LIBRARY is used, molecule is currently extending the path with the contents of the found variable, however, this will cause problems as the system driven path will conflict with a user defined path. To correct this issue the path processing will now insert the user provided variable into the path. - Bugfix Pull Request Lanuch-Pad: https://bugs.launchpad.net/tripleo/+bug/1930757 Signed-off-by: Kevin Carter <kecarter@redhat.com>
cloudnull
force-pushed
the
ansible-library
branch
from
33306f6
to
238cf2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the environment variable ANSIBLE_LIBRARY is used, molecule is
currently extending the path with the contents of the found variable,
however, this will cause problems as the system driven path will
conflict with a user defined path. To correct this issue the path
processing will now insert the user provided variable into the path.
Signed-off-by: Kevin Carter kecarter@redhat.com
Please include details of what it is, how to use it, how it's been tested
PR Type