Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of pytest-helpers-namespace #3195

Merged
merged 1 commit into from Jul 19, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jul 18, 2021

Related: saltstack/pytest-helpers-namespace#10

This change is not marked as major because it will only break testing of some molecule drivers. Most important ones were already fixed before this change was made.

@ssbarnea ssbarnea added the bug label Jul 18, 2021
@ssbarnea ssbarnea force-pushed the fix/rm-pytest-helpers-namespace branch from d05a794 to 960414c Compare July 18, 2021 12:24
@ssbarnea ssbarnea force-pushed the fix/rm-pytest-helpers-namespace branch from 960414c to 17acb20 Compare July 19, 2021 06:22
@ssbarnea ssbarnea marked this pull request as ready for review July 19, 2021 06:32
@ssbarnea ssbarnea requested a review from tadeboro as a code owner July 19, 2021 06:32
@ssbarnea ssbarnea added the major label Jul 19, 2021
@ssbarnea ssbarnea merged commit 769658d into master Jul 19, 2021
@ssbarnea ssbarnea deleted the fix/rm-pytest-helpers-namespace branch July 19, 2021 06:45
ssbarnea added a commit to ansible-community/molecule-podman that referenced this pull request Jul 19, 2021
ssbarnea added a commit to ansible-community/molecule-podman that referenced this pull request Jul 19, 2021
ssbarnea added a commit to ansible-community/molecule-podman that referenced this pull request Jul 19, 2021
apatard added a commit to apatard/molecule-vagrant that referenced this pull request Jul 22, 2021
… helpers

Since ansible/molecule#3195, molecule pytest
helpers are gone, so remove the code using them to use directly the molecule_directory()
function.

Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea pushed a commit to ansible-community/molecule-vagrant that referenced this pull request Jul 22, 2021
Since ansible/molecule#3195, molecule pytest
helpers are gone, so remove the code using them to use directly the molecule_directory()
function.

Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea added a commit to ansible-community/molecule-containers that referenced this pull request Jul 23, 2021
ssbarnea added a commit to ansible-community/molecule-containers that referenced this pull request Jul 23, 2021
ssbarnea added a commit to ansible-community/molecule-containers that referenced this pull request Jul 23, 2021
ssbarnea added a commit to ansible-community/molecule-containers that referenced this pull request Jul 23, 2021
@ssbarnea ssbarnea removed the major label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants