Ensure cwd is passed to utils.run_command() in all cases #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akerouanton
requested review from
ssbarnea,
tadeboro and
webknjaz
as code owners
Fixes #151. When trying to access Ansible vars in testinfra tests, the following function call would fail to get values coming from host/group vars: ansible_vars = host.ansible('debug', 'msg={{ hostvars[inventory_hostname] }}') This was due to: 1. testinfra being executed into the directory where molecule was launched instead of the scenario directory ; 2. group_vars being located in the scenario directory. This fix set the cwd passed to subprocess_tee to the cwd set in BakedCommand and fixes the issue. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
ssbarnea
changed the title
ssbarnea
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to access Ansible vars in testinfra tests, the following
function call would fail to get values coming from host/group vars:
This was due to: 1. testinfra being executed into the directory where
molecule was launched instead of the scenario directory ; 2. group_vars
being located in the scenario directory.
This fix set the cwd passed to subprocess_tee to the cwd set in
BakedCommand and fixes the issue.
I tested this change by directly changing molecule code in my project and
printing the output of the above line. It shows my group vars as expected.
Fixes #151