Drop testing of digitalocean, hetznercloud, lxd and openstack plugins #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
approved these changes
Nov 26, 2021
ssbarnea
changed the title
ssbarnea
force-pushed
the
fix/deps
branch
2 times, most recently
from
f1fe291
to
3abc293
Compare
While trying to fix some conflicts caused by this driver, I discovered that it did not receive any active maintenance in almost two years. Related: ansible-community/molecule-digitalocean#3 (comment)
* Fixes plugin testing pipeline by removing unmaintained plugins which affected it and upgrading dependencies for maintained ones.
ssbarnea
changed the title
ganeshrn
approved these changes
Dec 2, 2021
tadeboro
approved these changes
Dec 2, 2021
webknjaz
reviewed
Dec 2, 2021
| deps = | ||
| # we install test extra in order to validate it does not drag ansible in |
There was a problem hiding this comment.
In the future, it's best to move those dependencies to a proper location because the end-users don't need it (plus it's easier to maintain and repin automatically).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing these 4 drivers from testing due to being mostly unmaintained. If situation changes we can add them back. No real impact on module as that only affected our ecosystem pipeline.
Related: