Fix prepare_environment call for role installs #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffaluff
requested review from
ssbarnea,
tadeboro and
webknjaz
as code owners
|
That fix has a serious problem: it does not include a test so we would not see similar regression again. |
giner
added a commit
to giner/ansible-role-tfenv
that referenced
this pull request
Feb 1, 2022
To be removed after the fix is released, see ansible/molecule#3409
giner
added a commit
to giner/ansible-role-tfenv
that referenced
this pull request
Feb 1, 2022
To be removed after the fix is released, see ansible/molecule#3409
giner
added a commit
to giner/ansible-role-barman
that referenced
this pull request
Feb 1, 2022
To be removed after the fix is released, see ansible/molecule#3409
|
Is there a way we can get this PR in a good state to merge? All of my molecule pipelines are currently broken due to this. (the temporary fix referenced through the commits in this PR is an intermediary bypass). |
|
I've added an assertion to one of the tests to check that the role symbolic link is successfully created. Let me know if there are any other changes you want me to make. |
ssbarnea
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes local role installations with
ansible-compatversion 1.0.0 as discussed in issue #3404.