Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform env expects a dict of vars #3690

Merged
merged 2 commits into from Oct 21, 2022
Merged

Platform env expects a dict of vars #3690

merged 2 commits into from Oct 21, 2022

Conversation

zeitounator
Copy link
Contributor

Fixes #3684

@zeitounator zeitounator requested review from a team as code owners October 20, 2022 15:38
@zeitounator zeitounator requested review from Shaps, zhan9san, ganeshrn, cidrblock and shatakshiiii and removed request for a team October 20, 2022 15:38
@github-actions github-actions bot added the bug label Oct 20, 2022
@zeitounator zeitounator changed the title Schema should accept either a dict or list for env Platform env expects a dict of vars Oct 20, 2022
@zhan9san
Copy link
Contributor

Hi @zeitounator

I notice the 'ALl checks have passed'

Do you still have concern?

@zeitounator
Copy link
Contributor Author

@zhan9san Please see my comments in the corresponding issue. All good on my side for this particular problem.

@zhan9san zhan9san merged commit c6e2dbb into ansible:main Oct 21, 2022
@zeitounator zeitounator deleted the fix/env_schema_validation branch October 23, 2022 11:57
davedittrich pushed a commit to davedittrich/molecule that referenced this pull request Oct 24, 2022
@zeitounator @davedittrich
Platform env expects a dict of vars (ansible#3690)
85410d0 
* Platform `env` expects a dict of vars

* Fix corresponding test + coding standard
@zhan9san zhan9san mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaps Shaps Awaiting requested review from Shaps Shaps was automatically assigned from ansible-community/molecule

@zhan9san zhan9san Awaiting requested review from zhan9san zhan9san was automatically assigned from ansible-community/molecule

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn was automatically assigned from ansible-community/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock was automatically assigned from ansible-community/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

molecule.yml: platforms[].env cannot be a dictionary
2 participants
@zeitounator @zhan9san