Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Support for Shell Type Instance Param to Delegated Driver #3932

Merged
merged 4 commits into from Jun 12, 2023
Merged

Adds Support for Shell Type Instance Param to Delegated Driver #3932

merged 4 commits into from Jun 12, 2023

Conversation

zollo
Copy link
Contributor

@zollo zollo commented Jun 9, 2023

Addresses #3930

This bugfix (although it could be seen as a feature) adds missing support for the shell_type param in the Molecule instance for the delegated driver - this is then mapped to ansible_shell_type in the Molecule managed inventory.

@zollo zollo requested review from a team as code owners June 9, 2023 13:58
@zollo zollo requested review from greg-hellings, odyssey4me, cidrblock, priyamsahoo and shatakshiiii and removed request for a team June 9, 2023 13:58
@ssbarnea ssbarnea added the bug label Jun 12, 2023
@ssbarnea ssbarnea changed the title Bugfix/ISSUE-3930 Adds Support for Shell Type Instance Param to Delegated Driver Adds Support for Shell Type Instance Param to Delegated Driver Jun 12, 2023
@ssbarnea ssbarnea merged commit 5b750ff into ansible:main Jun 12, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@greg-hellings greg-hellings Awaiting requested review from greg-hellings greg-hellings was automatically assigned from ansible-community/molecule

@odyssey4me odyssey4me Awaiting requested review from odyssey4me odyssey4me was automatically assigned from ansible-community/molecule

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zollo @ssbarnea