Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Molecule uses ANSIBLE_FILTER_PLUGINS #4135

Merged
merged 11 commits into from Apr 8, 2024
Merged

Molecule uses ANSIBLE_FILTER_PLUGINS #4135

merged 11 commits into from Apr 8, 2024

Conversation

ultral
Copy link
Contributor

@ultral ultral commented Feb 9, 2024

if ANSIBLE_FILTER_PLUGINS set then molecule uses it instead of hardcoded paths. closes #3839

@ultral ultral requested a review from a team as a code owner February 9, 2024 10:19
@github-actions github-actions bot added the bug label Feb 9, 2024
@ssbarnea ssbarnea changed the title molecule uses ANSIBLE_FILTER_PLUGINS Molecule uses ANSIBLE_FILTER_PLUGINS Mar 11, 2024
@ssbarnea ssbarnea enabled auto-merge (squash) March 11, 2024 16:57
@ultral
Copy link
Contributor Author

ultral commented Mar 12, 2024

it failed because reached the rate limis

debug - 2024-03-11 17:01:51,789 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 429', params={}, description='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 315 seconds.\"}'), warnings=[], status_code=429, text='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 315 seconds.\"}')"}
error - 2024-03-11 17:01:51,790 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 315 seconds."}

@ultral
Copy link
Contributor Author

ultral commented Apr 5, 2024

@ssbarnea @shatakshiiii @Qalthos it looks like there was a bug on CI/CD side because of flapping tests. can we re-run it?

@ssbarnea ssbarnea merged commit 54e52eb into ansible:main Apr 8, 2024
15 checks passed
This was referenced Apr 12, 2024
Closed
Merged
ssbarnea pushed a commit that referenced this pull request Apr 12, 2024
@expeehaa
Fix test method name. (#4165)
2af568b 
This appears to have been missed while reviewing #4135. If I understand
the [pytest
docs](https://docs.pytest.org/en/8.0.x/explanation/goodpractices.html#test-discovery)
correctly, the method is not recognized as a test without the change.

This pull request is nearly identical to #4164, which I accidentally
closed and was unable to reopen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

molecule ignores ANSIBLE_FILTER_PLUGINS env var
2 participants
@ultral @ssbarnea