Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: switch to 2 shards instead of 3 #2255

Merged
merged 1 commit into from
Aug 30, 2019
Merged

travis: switch to 2 shards instead of 3 #2255

merged 1 commit into from
Aug 30, 2019

Conversation

ssbarnea
Copy link
Member

Using only 2 shards should be fine and will speedup testing by avoiding the queue waiting for new VMs.

@ssbarnea
travis: switch to 2 shards instead of 3
ed5e76e 
Using only 2 shards should be fine and will speedup testing by avoding
the queue waiting for new VMs.

Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
decentral1se
decentral1se previously requested changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what is being removed here in terms of the testing? The shard is gone but what was being run on that shard? Isn't there code in the conftest.py that relies on this number of shards being configured? Please elaborate.

@ssbarnea
Copy link
Member Author

@decentral1se AFAIK this is running the same tests, nothing is removed. The code in conftest does split the test in shards based on the mark used by parsing it: using shard_x_of_y is parsed and the number of shards is taken out of "y". Please double check but this is how I read it.

@ssbarnea ssbarnea added the test Improvement to quality assurance: CI/CD, testing, building label Aug 29, 2019
@ssbarnea ssbarnea self-assigned this Aug 29, 2019
@ssbarnea ssbarnea added this to the 3.0 milestone Aug 29, 2019
@ssbarnea ssbarnea dismissed decentral1se’s stale review August 29, 2019 15:59

261 tests for py27: before split in 3 groups of ~87, no in two of ~130

decentral1se
decentral1se approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that'll do it then 👍

@ssbarnea ssbarnea merged commit af0a943 into ansible:master Aug 30, 2019
@ssbarnea ssbarnea deleted the fix/2shards branch October 18, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decentral1se decentral1se decentral1se approved these changes

@cloudnull cloudnull Awaiting requested review from cloudnull

@LukeShortCloud LukeShortCloud Awaiting requested review from LukeShortCloud

@gabrielecerami gabrielecerami Awaiting requested review from gabrielecerami

Assignees

@ssbarnea ssbarnea

Labels
test Improvement to quality assurance: CI/CD, testing, building
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ssbarnea @decentral1se