ec2: per-platform ansible_connection overrides and win password lookup #2271
Conversation
There was a problem hiding this comment.
Thanks for this. Haven't tested it but here's a review pass. Given that we're in the process of migrating our drivers out of the core and into plugins, I am unsure if we'll be merging this now or a bit later. Perhaps now is easier? /cc @ssbarnea
To provision Linux & Windows hosts simultaneously, the same connection_options can't be shared on the provisioner. This commit allows provisioner connection_options to be customized per-platform. Additionally, if the winrm connection is used on an EC2 instance and a password isn't supplied. the password will be retried automatically via boto3 (decryption logic copied from ec2_win_password module) Signed-off-by: troyready <troy@troyready.com>
Signed-off-by: troyready <troy@troyready.com>
Signed-off-by: troyready <troy@troyready.com>
Signed-off-by: troyready <troy@troyready.com>
|
Sure thing - fixed |
There was a problem hiding this comment.
This is looking fine then!
I would rather reduce the noise of chaning quotes from single / double but can let that pass for now.
Thanks for taking time to work on this @troyready 🚀
|
I couldn't agree more about the quotes; I'd be happy to change them back (and have this PR only include relevant changes), but from what I could tell CI was failing because (i.e. it was still failing after the rebase and the only way to get it to exit zero was to run the file through black) |
Ah, I see. The Black invocation should be picking up the standard configuration over in https://github.com/ansible/molecule/blob/master/pyproject.toml#L11 which avoids changing quotes. Invoking it through Tox should pick this all up automatically 😕 |
PR Type
Overview
To provision Linux & Windows hosts simultaneously, the same connection_options can't be shared on the provisioner. This PR allows provisioner connection_options to be customized per-platform.
Additionally, if the winrm connection is used on an EC2 instance and a password isn't supplied. the password will be retrieved automatically via boto3 (decryption logic copied from ec2_win_password module)