refactoring: driver listing #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces mypy so we can do better type checking on our upcoming API. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
- easy access to plugins (drivers or verifiers) - enables mypy for api methods - simplified driver plugin loading (based on verifiers approach) Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
decentral1se
approved these changes
Sep 15, 2019
| @@ -22,30 +22,20 @@ | |||
| from molecule import api | |||
|
|
|||
|
|
|||
| def test_api_drivers(): | |||
| def test_api_molecule_drivers_as_attributes(): | |||
There was a problem hiding this comment.
Suggested change
| def test_api_molecule_drivers_as_attributes(): | |
| def test_api_drivers_as_attributes(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
molecule.driveris prefered to molecule_driver.