Podman driver shouldn't define /sys/fs/cgroup vol #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since podman version 0.8.5 it has auto detected when the mounting of /sys/fs/cgroup is necessary and only mounts a subset of that dir as needed by the container runtime. In newer versions, explicitly defining this actually fails with an OCI runtime permission denied error. Therefore, not only is this not necessary but can cause failures for users. Signed-off-by: Adam Miller <admiller@redhat.com>
|
Travis CI failures look unrelated since the failure is in docker functional tests and this is a docs change on something not docker. |
|
Thanks! RE: CI, we need to merge #2354 first. |
ssbarnea
approved these changes
Oct 12, 2019
|
@maxamillion Thank you for this! 👍 @decentral1se This is exactly the problem I mentioned on IRC the other day. Would there be a chance to get this removed from the (published) 2.22 docs at https://molecule.readthedocs.io/en/stable/configuration.html#podman as well? Right now, the docs tend to lure the reader into a configuration that is very likely to fail (on newer podman versions), so it would be great to get this sorted out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since podman version 0.8.5 it has auto detected when the mounting of
/sys/fs/cgroup is necessary and only mounts a subset of that dir as
needed by the container runtime. In newer versions, explicitly
defining this actually fails with an OCI runtime permission denied
error. Therefore, not only is this not necessary but can cause
failures for users.
Signed-off-by: Adam Miller admiller@redhat.com
Please include details of what it is, how to use it, how it's been tested
Please include an entry in the CHANGELOG.md if the change will impact users.
PR Type