Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of future #2372

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Remove use of future #2372

merged 1 commit into from
Oct 16, 2019

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 15, 2019

Future was thowing some deprecation warnings (py37), is mainly unmaintained and it wasn't even listed as dependency of molecule. As we already already have six listed as a dependency and used in multiple places we can easily drop it.

PR Type

  • Bugfix Pull Request

Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why?

@ssbarnea
Copy link
Member Author

But why?

Updated message.

Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI says 🍏

@ssbarnea ssbarnea merged commit 5305e51 into master Oct 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/remove-future branch October 16, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants