Include registry in default base test images #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By including the registry in the base test image we assure that we can use it with both docker and podman as the former one may not have a default registry already configured. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
ssbarnea
added
driver-podman
test
|
@sshnaidm ^ this should make it easier for your podman change. |
sshnaidm
reviewed
Oct 23, 2019
....role_name}}/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/molecule.yml
Show resolved
Hide resolved
decentral1se
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Looks good other than https://github.com/ansible/molecule/pull/2394/files#r338219855 which looks like a typo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By including the registry in the base test image we assure that we
can use it with both docker and podman as the former one may not have
a default registry already configured.