Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move default environment variables #2397

Merged
merged 1 commit into from
Oct 24, 2019
Merged

test: move default environment variables #2397

merged 1 commit into from
Oct 24, 2019

Conversation

ssbarnea
Copy link
Member

Use pytest to provide default environment variables for testing instead
of defining them in multiple places.

This would enable users to run pytest outside tox without having to
define extra variables.

@ssbarnea ssbarnea added the test Improvement to quality assurance: CI/CD, testing, building label Oct 24, 2019
decentral1se
decentral1se approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@decentral1se decentral1se left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this does just move them around so I don't really agree that we're consolidating (env vars now in pytest and Tox now, meaning, multiple places). However, I'm all for making Tox + Pytest just work TM, so let's go with this.

@ssbarnea ssbarnea changed the title test: consolidate default environment variables test: move default environment variables Oct 24, 2019
@ssbarnea
move test default environment variables
081cd32 
Use pytest to provide default environment variables for testing instead
of defining them in multiple places.

This would enable users to run pytest outisde tox without having to
define extra variables.

Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
@ssbarnea ssbarnea merged commit f5ff15f into ansible:master Oct 24, 2019
@ssbarnea ssbarnea deleted the fix/env branch October 25, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decentral1se decentral1se decentral1se approved these changes

Assignees
No one assigned
Labels
test Improvement to quality assurance: CI/CD, testing, building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ssbarnea @decentral1se