Remove molecule container building from core #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container building, testing and publishing will not be taken care of by https://github.com/ansible-community/molecule-dist project.
ssbarnea
requested review from
greg-hellings,
geerlingguy,
a team and
apatard
apatard
approved these changes
Oct 31, 2020
There was a problem hiding this comment.
I'm not sure what's the use of it, but if it's there, I guess some people are needing that. But
I agree that this should be handled elsewhere. Splitting is more flexible. For instance, it will allow people who can fix any problem with it to release a fixed version without waiting for a new molecule release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container building, testing and publishing will not be taken care of by https://github.com/ansible-community/molecule-dist project.
Main reason for this move is the fact that container building is distribution issue with specific
issues. Apparently the build process itself seems to be break quite easy for reasons outside the project (usually building some dependencies).
Decoupling of container building follows a distribution model that is also used by Ansible itself. The new project will also be able to produce other kind of packaging like debs, rpms, snaps,...