Add custom url download and selinux for jws #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
force-pushed
the
offline_or_alt_url
branch
6 times, most recently
from
5f744f8
to
6d83091
Compare
guidograzioli
force-pushed
the
offline_or_alt_url
branch
7 times, most recently
from
dfaeaca
to
051ba47
Compare
guidograzioli
force-pushed
the
offline_or_alt_url
branch
from
051ba47
to
5dc75ab
Compare
rpelisse
reviewed
Mar 24, 2022
roles/jws/vars/main.yml
Outdated
| @@ -64,7 +64,7 @@ tomcat: | |||
| stickySessionRemove: "{{ tomcat_modcluster_stickySessionRemove }}" | |||
| service: | |||
| enabled: "{{ tomcat_systemd_enabled }}" | |||
| name: "{{ tomcat_service_name }}" | |||
| name: "{{ tomcat_service_name }}.service" | |||
There was a problem hiding this comment.
@guidograzioli not a big deal, but I did it differently. I've added this .service where its needed only (so in the validation part).
rpelisse
approved these changes
Mar 24, 2022
guidograzioli
force-pushed
the
offline_or_alt_url
branch
from
5dc75ab
to
bd17678
Compare
guidograzioli
force-pushed
the
offline_or_alt_url
branch
from
bd17678
to
095c53a
Compare
This was referenced Mar 24, 2022
guidograzioli
added
the
minor_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9 #41 #42
This is now ready
pending github actions build (service is currently down)