Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pip specifier syntax like pywinrm[credssp]==0.4.3 #671

Closed
sbancal opened this issue Apr 17, 2024 · 2 comments · Fixed by #664
Closed

Add support for pip specifier syntax like pywinrm[credssp]==0.4.3 #671

sbancal opened this issue Apr 17, 2024 · 2 comments · Fixed by #664

Comments

@sbancal
Copy link

sbancal commented Apr 17, 2024

In our project we need to install the pywinrm package. As described on https://pypi.org/project/pywinrm/ , we have added it to requirements.txt with the following syntax:

pywinrm[credssp]==0.4.3

When we run ansible-builder build, we see that this line has been simplified to:

pywinrm==0.4.3

which means that the requests-credssp dependency has been forgotten.

Browsing the ansible-builder's code a bit, we found that it's introspect.py's sanitize_requirements function that does this.

def sanitize_requirements(collection_py_reqs):

Would it be possible to add support for this standard pip syntax ?

@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Apr 17, 2024
@kurokobo
Copy link

This may be addressed by #664 since the syntax is in pep508.

@Shrews Shrews linked a pull request Apr 17, 2024 that will close this issue
5 tasks
@Shrews
Copy link
Contributor

Shrews commented Apr 17, 2024

We expect this to be handled in the 3.1 release.

@Shrews Shrews removed the needs_triage New item that needs to be triaged label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants