Skip to content
This repository has been archived by the owner on Mar 23, 2019. It is now read-only.

Upgrade to Docker 1.12 #314

Closed
chouseknecht opened this issue Nov 18, 2016 · 5 comments · Fixed by #316
Closed

Upgrade to Docker 1.12 #314

chouseknecht opened this issue Nov 18, 2016 · 5 comments · Fixed by #316
Assignees
Milestone

Comments

@chouseknecht
Copy link
Contributor

chouseknecht commented Nov 18, 2016

Tracking progress on completing the upgrade to Docker 1.12 and hopefully adding support of Docker for Mac

@chouseknecht
Copy link
Contributor Author

  • files in container/templates have been updated to install docker-latest rpm, docker-compose 1.8.1, and docker-py 1.10.3
  • .travis.yml no longer downgrades Docker to 1.11.2
  • updated ansible/ansible-container-testing image

@chouseknecht
Copy link
Contributor Author

chouseknecht commented Nov 18, 2016

Running into this issue: docker/for-mac#865

  • upgraded Docker for Mac to 1.12.3-beta30.1(13946)
  • Tests pass
  • However, this error appears without interrupting anything:
test_1               | test/integration/test_slow.py::test_restart_minimal_docker_container PASSED
Exception in thread Thread-3:
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/local/lib/python2.7/site-packages/docker_compose-1.8.1-py2.7.egg/compose/cli/log_printer.py", line 197, in watch_events
    for event in event_stream:
  File "/usr/local/lib/python2.7/site-packages/docker_compose-1.8.1-py2.7.egg/compose/project.py", line 343, in events
    decode=True
  File "/usr/local/lib/python2.7/site-packages/docker_py-1.10.3-py2.7.egg/docker/client.py", line 259, in _stream_helper
    data = json.loads(data)
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/__init__.py", line 339, in loads
    return _default_decoder.decode(s)
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 367, in decode
    raise ValueError(errmsg("Extra data", s, end, len(s)))
ValueError: Extra data: line 2 column 1 - line 2 column 678 (char 674 - 1351)

@chouseknecht
Copy link
Contributor Author

chouseknecht commented Nov 18, 2016

Looks like I'm seeing this issue: docker/compose#4090

@chouseknecht
Copy link
Contributor Author

chouseknecht commented Nov 18, 2016

Testing with docker-py 1.10.6, docker-compose 1.9.0 and Docker for Mac 1.12.3-beta30.1

Still hitting docker/compose#4090

  • appears to be related to restarting a stopped project.
  • only happens when running tests using python 2.7.12
  • tests pass despite the error
Exception in thread Thread-3:
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/local/lib/python2.7/site-packages/docker_compose-1.9.0-py2.7.egg/compose/cli/log_printer.py", line 197, in watch_events
    for event in event_stream:
  File "/usr/local/lib/python2.7/site-packages/docker_compose-1.9.0-py2.7.egg/compose/project.py", line 343, in events
    decode=True
  File "/usr/local/lib/python2.7/site-packages/docker_py-1.10.6-py2.7.egg/docker/client.py", line 261, in _stream_helper
    data = json.loads(data)
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/__init__.py", line 339, in loads
    return _default_decoder.decode(s)
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 367, in decode
    raise ValueError(errmsg("Extra data", s, end, len(s)))
ValueError: Extra data: line 2 column 1 - line 2 column 678 (char 674 - 1351)
Exception in thread Thread-6:
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/local/lib/python2.7/site-packages/docker_compose-1.9.0-py2.7.egg/compose/cli/log_printer.py", line 197, in watch_events
    for event in event_stream:
  File "/usr/local/lib/python2.7/site-packages/docker_compose-1.9.0-py2.7.egg/compose/project.py", line 343, in events
    decode=True
  File "/usr/local/lib/python2.7/site-packages/docker_py-1.10.6-py2.7.egg/docker/client.py", line 261, in _stream_helper
    data = json.loads(data)
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/__init__.py", line 339, in loads
    return _default_decoder.decode(s)
  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 367, in decode
    raise ValueError(errmsg("Extra data", s, end, len(s)))
ValueError: Extra data: line 2 column 1 - line 2 column 678 (char 674 - 1351)


test_1               | test/integration/test_slow.py::test_restart_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_restart_service_minimal_docker_container PASSED

Running tests with python 3.5.0 does not produce the error:

test_1               | ============================= test session starts ==============================
test_1               | platform linux -- Python 3.5.0, pytest-3.0.4, py-1.4.31, pluggy-0.4.0 -- /tmp/py35/bin/python3.5
test_1               | cachedir: .cache
test_1               | rootdir: /Users/chouseknecht/projects/ansible-container, inifile:
test_1               | plugins: timeout-1.2.0, cov-2.4.0
test_1               | timeout: 120.0s method: signal
test_1               | collecting ... collected 31 items
test_1               |
test_1               | test/integration/test_fast.py::test_invalid_command_fails PASSED
test_1               | test/integration/test_fast.py::test_no_command_shows_help PASSED
test_1               | test/integration/test_fast.py::test_help_command_shows_help PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_run_command PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_stop_command PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_restart_command PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_help_command PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_shipit_command PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_shipit_engine_command PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_init_command PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_build_command PASSED
test_1               | test/integration/test_fast.py::test_help_option_shows_help_for_push_command PASSED
test_1               | test/integration/test_fast.py::test_run_in_uninitialized_directory_fails PASSED
test_1               | test/integration/test_fast.py::test_shipit_in_uninitialized_directory_fails PASSED
test_1               | test/integration/test_fast.py::test_init_empty_directory PASSED
test_1               | test/integration/test_slow.py::test_build_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_build_with_variables PASSED
test_1               | test/integration/test_slow.py::test_build_with_volumes PASSED
test_1               | test/integration/test_slow.py::test_run_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_run_minimal_docker_container_in_detached_mode PASSED
test_1               | test/integration/test_slow.py::test_stop_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_stop_service_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_force_stop_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_force_stop_service_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_restart_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_restart_service_minimal_docker_container PASSED
test_1               | test/integration/test_slow.py::test_build_with_var_file PASSED
test_1               | test/integration/test_slow.py::test_run_with_var_file PASSED
test_1               | test/integration/test_slow.py::test_install_role_requirements PASSED
test_1               | test/integration/test_slow.py::test_setting_ansible_container_envar PASSED
test_1               |
test_1               |  generated xml file: /Users/chouseknecht/projects/ansible-container/test/reports/integration/junit.xml
test_1               | ========================= 31 passed in 453.37 seconds ==========================

@chouseknecht
Copy link
Contributor Author

chouseknecht commented Nov 18, 2016

The error is NOT manifesting on Travis: https://travis-ci.org/ansible/ansible-container/builds/177112506

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants