Make all rule identifiers text based #1306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we v5 is already a major version, we also take the opportunity to replace all numeric rule ids with text one, like pylint has.
The main reason for this is that the numeric ones were cryptic, while the new ones should be self-documented, at least for most cases.
While this rule changes the output due to new codes being printed it is backwards compatible as old codes are recognized, so users are not forced to update their skip lists when they upgrade. This should ease upgrades.
Checklist
-L
produce better results than in the past-T
and assure that we do not have incorrect, redundant or confusing entriesExample output of new rule IDs, do you find one that does not make sense? or that can better rephrased? Keep in mind that these IDs must be under ~30ch, and that they are followed by their shortdesc in most cases.: