Avoid duplicating molecule requirements.yml files #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l files When running ansible-lint on roles with molecule scenarii, it will run syntax-check on the scenarii but won't find the needed roles (if any). The current solution is to write a requirements.yml file in the top of the directory merging all molecule/*/requirements.yml files but it's duplication and create an extra file only to get ansible-lint playbook check working. As a solution, look for molecule/*/requirements.yml and install dependencies from them too. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea
changed the title
ssbarnea
approved these changes
Apr 8, 2021
ssbarnea
requested review from
geerlingguy,
greg-hellings,
MarkusTeufelberger and
odyssey4me
greg-hellings
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running ansible-lint on roles with molecule scenarii, it will
run syntax-check on the scenarii but won't find the needed roles
(if any). The current solution is to write a requirements.yml file
in the top of the directory merging all molecule//requirements.yml files
but it's duplication and create an extra file only to get ansible-lint
playbook check working.
As a solution, look for molecule//requirements.yml and install
dependencies from them too.
Signed-off-by: Arnaud Patard apatard@hupstream.com