Ignore empty env variable values when updating them #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase so we get rid of the fixed Ci issues. |
Right now, if the variable is not set, prerun routines will preped the : to the variable value, which is not something we want. This commit makes sure we properly handle the aforementioned situation and ignore any empty values.
tadeboro
force-pushed
the
fix-bad-env-var-list-construction
branch
from
06f0e70
to
d021d3d
Compare
ssbarnea
approved these changes
May 18, 2021
|
Hmm, looks like I broke something since the eco test is failing. This sounds like an interesting problem. |
Yep, I already contacted @greg-hellings on that. It may be possible to be a bug in his role testing that your fix uncovered. Ansible is unable to find that action plugin after this change. Lets see which one finds the root cause for that. |
ssbarnea
added a commit
to ssbarnea/ansible_collection_system
that referenced
this pull request
May 18, 2021
Collection layout expectes all action plugins to be inside plugins/modules. Found while testing: ansible/ansible-lint#1552
ssbarnea
added a commit
to ssbarnea/ansible_collection_system
that referenced
this pull request
May 18, 2021
Collection layout expectes all action plugins to be inside plugins/modules. Found while testing: ansible/ansible-lint#1552
ssbarnea
added a commit
to ssbarnea/ansible_collection_system
that referenced
this pull request
May 18, 2021
Collection layout expectes all action plugins to be inside plugins/modules. Found while testing: ansible/ansible-lint#1552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if the variable is not set, prerun routines will prepend the
:to the variable value, which is not something we want. This commit makes sure we properly handle the aforementioned situation and ignore any empty values.Should fix the problem described in ansible/molecule#3122