Use packit to produce rpms for fedora-35 #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
feature/distro-packaging
branch
from
0e92faf
to
4f95b37
Compare
ssbarnea
force-pushed
the
feature/distro-packaging
branch
2 times, most recently
from
96d0f3c
to
1e665ff
Compare
ssbarnea
force-pushed
the
feature/distro-packaging
branch
from
1e665ff
to
7196bd1
Compare
webknjaz
reviewed
Jul 8, 2021
ssbarnea
force-pushed
the
feature/distro-packaging
branch
from
7196bd1
to
ef7eaee
Compare
|
Did you make any progress on the rpm packaging in the meantime? Is there anything we can help with? |
|
No progress as I got other priorities, not sure when I will be able to return to this one. Feel free to work on it. |
|
I can see that all builds on Fedora and el8 are passing: what's left to be done? |
webknjaz
reviewed
Aug 11, 2021
webknjaz
reviewed
Aug 11, 2021
webknjaz
reviewed
Aug 11, 2021
.packit.yaml
Outdated
| - job: copr_build | ||
| metadata: | ||
| targets: | ||
| # Unable to build centos-stream due to missing python3-setuptools_scm_git_archive |
There was a problem hiding this comment.
Why not patch it out in the spec file? It's not like there's nowhere to get the version from.
webknjaz
reviewed
Aug 11, 2021
webknjaz
reviewed
Aug 11, 2021
.packit.yaml
Outdated
| - "python3 setup.py --version" | ||
| post-upstream-clone: | ||
| - | | ||
| bash -c "sed -i -e 's/Version: VERSION_PLACEHOLDER/Version: $(python3 setup.py --version)/' ansible-lint.spec" |
There was a problem hiding this comment.
Suggested change
| bash -c "sed -i -e 's/Version: VERSION_PLACEHOLDER/Version: $(python3 setup.py --version)/' ansible-lint.spec" | |
| bash -c "sed -i -e 's/Version: VERSION_PLACEHOLDER/Version: $(python3 -m setuptools_scm | awk '{print $3}')/' ansible-lint.spec" |
webknjaz
reviewed
Aug 11, 2021
webknjaz
reviewed
Aug 11, 2021
ssbarnea
force-pushed
the
feature/distro-packaging
branch
7 times, most recently
from
0c6ae2a
to
dfc9885
Compare
ssbarnea
force-pushed
the
feature/distro-packaging
branch
2 times, most recently
from
af649c7
to
72b7e5c
Compare
ssbarnea
added a commit
to ssbarnea/ansible-lint
that referenced
this pull request
Feb 18, 2022
This configures setuptools-scm to cache version when installing or building the package, so we no longer need to use pkg_resources to gather the version. This removes the need for setuptools at runtime and also improve performance as version is loaded directly from our module, when present. Related: ansible#1648
ssbarnea
force-pushed
the
feature/distro-packaging
branch
4 times, most recently
from
b0dfd80
to
e20131a
Compare
ssbarnea
changed the title
ssbarnea
force-pushed
the
feature/distro-packaging
branch
from
e20131a
to
dbb4bf7
Compare
ssbarnea
force-pushed
the
feature/distro-packaging
branch
from
dbb4bf7
to
c414f0e
Compare
ssbarnea
added
AAP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.