Move ansiblelint.testing.RunFromText import into test code #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
relrod,
cidrblock and
priyamsahoo
and removed request for
a team
|
I'm not sure what to do about codecov here. How does moving an import into test code change the code coverage? Odd. |
|
@cognifloyd I will check, from time to time I need to ignore coverage result. Rounding errors can make it go down. |
ssbarnea
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the rules were importing test code even outside of the testing block. This fixes that so there are no unintended side-effects of importing the testing code.
In particular, importing that testing code should be delayed so that
prepare_environment()doesn't get called when importing the rule:https://github.com/ansible-community/ansible-lint/blob/main/src/ansiblelint/testing/__init__.py#L19-L21
It probably doesn't make a difference, but it was a code smell, so this cleans that up.