New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test integration with IDEs #1914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base args must be in pytest.ini
. Maintaining them only in tox will create an inconsistent experience. tox.ini
is only there for conditional overrides.
4434fdd
to
2f12680
Compare
2f12680
to
c877135
Compare
c877135
to
da945fc
Compare
da945fc
to
4deb38a
Compare
If you have an alternative that is fixing all the points noted in the description, I would be happy to see it. So far I was not the only contributor that found these issues inconvenient and I do not want to force anyone willing to contribute to alter his environment to make it work, especially as that might be even impossible without altering tracked files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything we can do to ensure the first time test running/debugging experience is smooth I'll +1
I that brings any regressions, we will fix them in follow-ups. @cognifloyd Please test and report if this is improving the experience for you. |
Nice. Works great in pycharm. |
Probably we can put back some arguments in pytest.ini if they do not break other tools. |
This should fix debugging tests in both vscode and pycharm. We need to be sure that we disable pytest-cov inside
pytest.ini
and enable it only withintox.ini
file.This ensures that we can:
tox -e py
(no posargs)Related: #1912 #1909