Improve version handling #1931
Merged
Improve version handling #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configures setuptools-scm to cache version when installing or building the package, so we no longer need to use pkg_resources to gather the version. This removes the need for setuptools at runtime and also improve performance as version is loaded directly from our module, when present. Related: ansible#1648
cognifloyd
approved these changes
Feb 18, 2022
ssbarnea
requested review from
ganeshrn and
priyamsahoo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configures setuptools-scm to cache version when installing or
building the package, so we no longer need to use pkg_resources
to gather the version.
This removes the need for setuptools at runtime and also improve
performance as version is loaded directly from our module, when
present.
Related: #1648