Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply MissingFilePermissionsRule to get_url module #1949

Merged
merged 4 commits into from Mar 5, 2022
Merged

Apply MissingFilePermissionsRule to get_url module #1949

merged 4 commits into from Mar 5, 2022

Conversation

nre-ableton
Copy link
Contributor

@nre-ableton nre-ableton commented Mar 3, 2022 •
edited by ssbarnea

The get_url module can create files and directories similar to the file and copy modules, so the mode parameter should be enforced for this module as well.

@nre-ableton
Apply MissingFilePermissionsRule to get_url module
26052d3 
The get_url module can create files and directories similar to the file
and copy modules, so the mode parameter should be enforced for this
module as well.
@nre-ableton nre-ableton requested a review from a team as a code owner March 3, 2022 17:29
@nre-ableton nre-ableton requested review from relrod, ssbarnea and ganeshrn and removed request for a team March 3, 2022 17:29
@ssbarnea ssbarnea added the bug label Mar 3, 2022
ssbarnea
ssbarnea requested changes Mar 3, 2022
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Please update the tests or the fixtures so they would not fail.

@nre-ableton
Copy link
Contributor Author

@ssbarnea Yes, of course, sorry. I agree that having a test would be appropriate. However, I'm not exactly sure where to add such a test... sorry, I'm unfamiliar with the ansible-lint codebase and this is my first contribution. I looked in several places but couldn't find similar tests for the archive and assemble modules (for example).

I pushed a fixup, please let me know if this would be sufficient for test coverage, and if so, I'll squash. Thanks!

@ssbarnea ssbarnea merged commit 24dd54a into ansible:main Mar 5, 2022
@nre-ableton
Copy link
Contributor Author

@ssbarnea Thanks for fixing the tests! I would have liked to have squashed my fixup, but I guess it's not a problem. Looking forward to the next release!

@ssbarnea
Copy link
Member

ssbarnea commented Mar 7, 2022

No need to worry about squash, we (almost) always do it, just to keep the history clean. We had cases with 100 commits, nobody wants to see each of them.

@nre-ableton nre-ableton deleted the nre/main/get_url-mode branch March 7, 2022 16:29
@ssbarnea ssbarnea mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@relrod relrod Awaiting requested review from relrod relrod was automatically assigned from ansible-community/devtools

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nre-ableton @ssbarnea