Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made empty-string-compare rule opt-in #1953

Merged
merged 1 commit into from Mar 5, 2022
Merged

Made empty-string-compare rule opt-in #1953

merged 1 commit into from Mar 5, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 5, 2022

Fixes: #457

@ssbarnea ssbarnea requested a review from a team as a code owner March 5, 2022 09:19
@ssbarnea ssbarnea requested review from relrod, ganeshrn and priyamsahoo and removed request for a team March 5, 2022 09:19
@ssbarnea ssbarnea added the bug label Mar 5, 2022
@ssbarnea ssbarnea added this to the 6.0.0 milestone Mar 5, 2022
@ssbarnea ssbarnea merged commit 3032f5e into ansible:main Mar 5, 2022
@ssbarnea ssbarnea deleted the fix/457 branch March 5, 2022 15:28
@ssbarnea ssbarnea mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@relrod relrod Awaiting requested review from relrod relrod was automatically assigned from ansible-community/devtools

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

@cognifloyd cognifloyd Awaiting requested review from cognifloyd

@odyssey4me odyssey4me Awaiting requested review from odyssey4me

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[E602] Don't compare to empty string - what's a better way?
2 participants
@ssbarnea @felixfontein