Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load rule classes from any modules #1978

Merged
merged 1 commit into from Mar 11, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 11, 2022

This change is preparing for #1977 so we can rename the module names that include rule classes. We no longer make the assumption that the module name must match that rule class name.

This change is preparing for ansible#1977 so we can rename the module
names that include classes. We no longer make the assumption that
the module name must match that rule class name.
@ssbarnea ssbarnea requested a review from a team as a code owner March 11, 2022 17:20
@ssbarnea ssbarnea requested review from relrod, ganeshrn and priyamsahoo and removed request for a team March 11, 2022 17:20
@ssbarnea ssbarnea changed the title fix/relax rule module names Load rule classes from any modules Mar 11, 2022
@github-actions github-actions bot added the bug label Mar 11, 2022
@ssbarnea ssbarnea added enhancement and removed bug labels Mar 11, 2022
@ssbarnea ssbarnea merged commit 775d826 into ansible:main Mar 11, 2022
@ssbarnea ssbarnea deleted the fix/relax-rule-module-names branch March 11, 2022 17:29
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. This is beautiful. I've looked at fixing this before but didn't see an elegant way to resolve this. 👍 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants