Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed rules to use docstring as shortdesc #1994

Merged
merged 1 commit into from Mar 14, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 14, 2022

Simplifies rule by ensuring that we do use the docstring as their short description. This also enables us to address most pylint no-class-docstring excludes.

That is an alternative to another linked PR I made yesterday where I tried to put the description in a docstring, but that proved to cause several problems related to formatting
of docstrings with rst. This approach is simple and without undesired effects.

Related: #1993

Simplifies rule by ensuring that we do use the docstring as their
short description. This also enables us to address most pylint
no-class-docstring excludes.
@ssbarnea ssbarnea marked this pull request as ready for review March 14, 2022 12:06
@ssbarnea ssbarnea requested a review from a team as a code owner March 14, 2022 12:06
@ssbarnea ssbarnea requested review from relrod, ganeshrn, priyamsahoo, cidrblock and a team and removed request for a team, relrod, ganeshrn and priyamsahoo March 14, 2022 12:06
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short_desc? I'm surprised it passed cspell :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants