--write: Avoid line-wrapping YAML flow objects #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When flow-objects (JSON-like YAML maps or lists) get dumped and their line length is too long, they can get wrapped in some very odd places. So, we calculate how long we expect the line-length might be for flow-style maps and lists. If it is short enough to fit on one line, we leave it in flow-style. If the line will (probably) be wrapped, we make that map/list use block-style instead of flow-style.
cognifloyd
commented
Mar 18, 2022
cognifloyd
commented
Mar 18, 2022
ssbarnea
approved these changes
Mar 19, 2022
ssbarnea
changed the title
--write: Avoid line-wrapping YAML flow objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When flow-objects (JSON-like YAML maps or lists) get dumped and their line length is too long, they can get wrapped in some very odd places.
This is a flow-style map:
{ foo: bar }This is a flow-style list:
[0, 1, 2, 3]So, we calculate how long we expect the line-length might be for flow-style maps and lists.
If it is short enough to fit on one line, we leave it in flow-style.
If the line will (probably) be wrapped, we make that map/list use block-style instead of flow-style.