Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name[template]: If a {{ }} is found in a task name, require it's presence at the end after a sentence explaining the task #2037

Closed
cidrblock opened this issue Mar 23, 2022 · 2 comments
Labels
AAP Ansible Automation Platform enhancement new rule A request for a new rule

Comments

@cidrblock
Copy link
Contributor

and that is has a meaningful name not item

This is ok:

name: "Start the requested service. {{ serivce_name }}"

This should not be:

name: "Enable {{ item.1 }}"

@cidrblock cidrblock added the new rule A request for a new rule label Mar 30, 2022
@ganeshrn ganeshrn added the AAP Ansible Automation Platform label May 9, 2022
@ssbarnea ssbarnea changed the title Rule request: If a {{ }} is found in a task name, require it's presence at the end after a sentence explaining the task name-templated: If a {{ }} is found in a task name, require it's presence at the end after a sentence explaining the task Jul 20, 2022
@ssbarnea ssbarnea changed the title name-templated: If a {{ }} is found in a task name, require it's presence at the end after a sentence explaining the task name[template]: If a {{ }} is found in a task name, require it's presence at the end after a sentence explaining the task Sep 24, 2022
@ssbarnea
Copy link
Member

Implemented and released.

@williamhanseneric
Copy link

Disagree with this being an area that the linter needs to be concerned with... unless there is a real problem with the implementation, doing things like this inline in an intelligent way is cleaner and better... the linter is too opinionated.

I want the linter to respond when something is not going to be supported in the future, or would lead to real usability issues. Having this show up in the "basic" profile is not the way IMHO.

  • name: Wait up to "{{ cli_conn_timeout }}" seconds for a machine connection before fact collection

  • name: "Retrieve stdout from {{ ansible_controller_tower_name }} for {{ tower_job_id }} on errors"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AAP Ansible Automation Platform enhancement new rule A request for a new rule
Projects
Status: Done
Archived in project
Development

No branches or pull requests

4 participants