--write: Allow Transforms to mark MatchErrors as fixed #2041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
MatchError.fixed
so that transforms can report when they have fixed a given issue.When a match is marked as "fixed", it is not included in the list of failures or warnings at the end of the run.
That should ensure that any remaining issues reported are actionable.
It also reports how many issues were fixed at the end of an
ansible-lint --write
run.When nothing was fixed, the report stays the same:
If nothing is fixed, but files were reformatted, the report looks like this:
If any matches were marked fixed then the report looks like this (anything in the "fixed" count is not counted in failures or warnings):