Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix var-naming rule to show line numbers and apply noqa #2090

Merged
merged 2 commits into from May 3, 2022
Merged

Fix var-naming rule to show line numbers and apply noqa #2090

merged 2 commits into from May 3, 2022

Conversation

notok
Copy link
Contributor

@notok notok commented Apr 30, 2022 •
edited

Currently, noqa for var-naming rule is not working for vars section in playbook and vars file.
This fix makes noqa working by getting line numbers from AnsibleUnicode.

Fixes #2040

@notok notok requested review from a team as code owners April 30, 2022 21:12
@github-actions github-actions bot added the bug label Apr 30, 2022
cognifloyd
cognifloyd approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

@ssbarnea ssbarnea merged commit bce29ae into ansible:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@cognifloyd cognifloyd cognifloyd approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression of var-naming can't be skipped
3 participants
@notok @ssbarnea @cognifloyd