New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule to check key order #2108
Conversation
@jeefberkey Please update PYTEST_REQPASS and increase its value to match expected number of tests (+2). |
Thanks for the additional guidance - |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
79bb644
to
3b6bc86
Compare
I am an rg user myself, great tool! I have an alias |
@jeefberkey I pushed some minor changes, like removing opt-int, we will make it experimental from start as it is very useful. |
Thanks for the test fixes, I was working on them but was sick the past few days. The new test name may conflict with other things I'm working on, but we can deal with that later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it.
Please mention more details about conflicts we might have? While class name is not important, the |
Nothing, this is actually not a blocker now that I think about it. |
Adds a new rule that for the moment checks that name is the first key on tasks. In the future
we will add additional ordering rules to it.
Partial: #578