Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name[casing] to identify wrongly capitalized task names #2274

Merged
merged 1 commit into from Aug 9, 2022
Merged

Add name[casing] to identify wrongly capitalized task names #2274

merged 1 commit into from Aug 9, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Aug 9, 2022 •
edited

As this is an extension to a current rule, we add it to the default warn_list, so it would only act as a warning. This functionality works only if user does not already have a custom warn_list.

Fixes: #2169

@ssbarnea ssbarnea marked this pull request as ready for review August 9, 2022 16:04
@ssbarnea ssbarnea requested review from a team as code owners August 9, 2022 16:04
@github-actions github-actions bot added the bug label Aug 9, 2022
@ssbarnea ssbarnea mentioned this pull request Aug 9, 2022
Merged
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this pull request Aug 9, 2022
@ssbarnea
Ensure test files use desired casing for name
7b3ab92 
Needed-By: ansible#2274
ssbarnea added a commit that referenced this pull request Aug 9, 2022
@ssbarnea
Ensure test files use desired casing for name (#2275)
8fc33cd 
Needed-By: #2274
@ssbarnea ssbarnea removed the bug label Aug 9, 2022
@github-actions github-actions bot added the bug label Aug 9, 2022
@ssbarnea ssbarnea removed the bug label Aug 9, 2022
@ssbarnea ssbarnea merged commit 720f0f7 into ansible:main Aug 9, 2022
@ssbarnea ssbarnea deleted the fix/name branch August 9, 2022 17:47
hswong3i added a commit to alvistack/ansible-role-audacious that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
0b117c8
hswong3i added a commit to alvistack/ansible-role-ansible that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
ff32756
hswong3i added a commit to alvistack/ansible-role-audacity that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
7b295b5
hswong3i added a commit to alvistack/ansible-role-bamboo that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
9e735b1
hswong3i added a commit to alvistack/ansible-role-bleachbit that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
ac56d44
hswong3i added a commit to alvistack/ansible-role-blender that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
7643890
hswong3i added a commit to alvistack/ansible-role-bitbucket that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
3e9cfca
hswong3i added a commit to alvistack/ansible-role-catatonit that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
4c060f3
hswong3i added a commit to alvistack/ansible-role-bootstrap that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
6fd8cb0
hswong3i added a commit to alvistack/ansible-role-buildah that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
f067de0
hswong3i added a commit to alvistack/ansible-role-operator_sdk that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
a0fea03
hswong3i added a commit to alvistack/ansible-role-packer that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
8fb171c
hswong3i added a commit to alvistack/ansible-role-php that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
7764b63
hswong3i added a commit to alvistack/ansible-role-podman that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
175eb9a
hswong3i added a commit to alvistack/ansible-role-postfix that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
d59b9df
hswong3i added a commit to alvistack/ansible-role-postgres that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
014072c
hswong3i added a commit to alvistack/ansible-role-python that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
6a1ba9b
hswong3i added a commit to alvistack/ansible-role-rclone that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
adc2c33
hswong3i added a commit to alvistack/ansible-role-scribus that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
f74596d
hswong3i added a commit to alvistack/ansible-role-runc that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
a0b69a6
hswong3i added a commit to alvistack/ansible-role-restic that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
251e573
hswong3i added a commit to alvistack/ansible-role-sonobuoy that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
4389329
hswong3i added a commit to alvistack/ansible-role-skopeo that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
92b3570
hswong3i added a commit to alvistack/ansible-role-sqlite that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
f50ad08
hswong3i added a commit to alvistack/ansible-role-sshd that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
85e7b15
hswong3i added a commit to alvistack/ansible-role-svn that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
f6127e6
hswong3i added a commit to alvistack/ansible-role-swap that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
195ca1a
hswong3i added a commit to alvistack/ansible-role-teams that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
2c3a78e
hswong3i added a commit to alvistack/ansible-role-transmission that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
eea7c30
hswong3i added a commit to alvistack/ansible-role-thunderbird that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
de02353
hswong3i added a commit to alvistack/ansible-role-teamviewer that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
14e48e5
hswong3i added a commit to alvistack/ansible-role-vim that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
ae1cf7d
hswong3i added a commit to alvistack/ansible-role-virtualbox that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
30b53f5
hswong3i added a commit to alvistack/ansible-role-vagrant that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
58aef0a
hswong3i added a commit to alvistack/ansible-role-uget that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
fd0947a
hswong3i added a commit to alvistack/ansible-role-zram_generator that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
66c24ee
hswong3i added a commit to alvistack/ansible-role-vlc that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
8a76e73
hswong3i added a commit to alvistack/ansible-role-wireguard that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
d3d71cc
hswong3i added a commit to alvistack/ansible-role-timezone that referenced this pull request Aug 22, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2274
e3f90c1
@DavisRayM DavisRayM mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name[casing]: All tasks should be named and start with a capital letter
2 participants
@ssbarnea @cidrblock