Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix identification of inline noqa skips #2300

Merged
merged 1 commit into from Sep 17, 2022
Merged

Fix identification of inline noqa skips #2300

merged 1 commit into from Sep 17, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Aug 15, 2022 •
edited

Fixes: #2271
Fixes: #2320

@ssbarnea ssbarnea requested review from a team as code owners August 15, 2022 17:12
@github-actions github-actions bot added the bug label Aug 15, 2022
cognifloyd
cognifloyd reviewed Aug 15, 2022
View reviewed changes
src/ansiblelint/rules/yaml.py Outdated Show resolved Hide resolved
src/ansiblelint/rules/yaml.py Outdated Show resolved Hide resolved
src/ansiblelint/rules/yaml.py Outdated Show resolved Hide resolved
cognifloyd
cognifloyd suggested changes Aug 17, 2022
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a couple cleanup suggestions earlier.

@ssbarnea ssbarnea marked this pull request as draft August 18, 2022 17:20
@ssbarnea ssbarnea mentioned this pull request Sep 1, 2022
Merged
@ssbarnea ssbarnea marked this pull request as ready for review September 17, 2022 11:47
@ssbarnea ssbarnea merged commit 4a8456a into ansible:main Sep 17, 2022
@ssbarnea ssbarnea deleted the fix/meta branch September 17, 2022 12:18
davedittrich pushed a commit to davedittrich/ansible-lint that referenced this pull request Sep 27, 2022
@ssbarnea @davedittrich
Fix identification of inline noqa skips (ansible#2300)
597cecc 
Fixes: ansible#2271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd requested changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@ssbarnea @cognifloyd