Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid erroring with empty vars files #2310

Merged
merged 1 commit into from Aug 20, 2022
Merged

Avoid erroring with empty vars files #2310

merged 1 commit into from Aug 20, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Aug 20, 2022 •
edited

That should fix some problems I spotted while working on #2306 with eco pipeline.

@ssbarnea ssbarnea requested review from a team as code owners August 20, 2022 14:52
@ssbarnea ssbarnea added the bug label Aug 20, 2022
@ssbarnea
Avoid erroring with empty vars files
8304a7b 
- Empty YAML files should not longer produce errors
- We now made the broad rule exception catching to warning instead of
  debug, so we make it less likely to miss these, especially as they
  are almost always sing of a corner-case that we did not cover.
@ssbarnea ssbarnea merged commit 7ad2aaf into ansible:main Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ssbarnea