Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subprocess.run for progressive mode #2319

Merged
merged 1 commit into from Aug 23, 2022

Conversation

kostyaplis
Copy link
Contributor

Fixes #2314

Several issues I've noticed with recently introduced subprocess.run for git commands in progressive mode:

  1. git rev-parse HEAD^1 returns a newline, so have to be stripped, otherwise error
  2. git worktree add -f worktree_dir uses shell=True. It expects a string so it fails with a list of arguments as reported in issue Progressive mode is broken as of 6.5.0 #2314 )
  3. git checkout revision uses shell=True. Same as above
  4. git worktree add -f worktree_dir uses check=True. It fails when the directory already exists. So each subsequent ansible-lint run will fail

@ssbarnea ssbarnea changed the title fix subprocess.run for progressive mode Fix subprocess.run for progressive mode Aug 23, 2022
@ssbarnea ssbarnea merged commit 3a0cbb5 into ansible:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progressive mode is broken as of 6.5.0
2 participants