Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name[casing]: now applies only to scripts supporting uppercase #2347

Merged
merged 1 commit into from Aug 27, 2022
Merged

name[casing]: now applies only to scripts supporting uppercase #2347

merged 1 commit into from Aug 27, 2022

Conversation

ssbarnea
Copy link
Member

Fixes: #2340

@ssbarnea ssbarnea requested review from a team as code owners August 27, 2022 07:48
@github-actions github-actions bot added the bug label Aug 27, 2022
@ssbarnea ssbarnea merged commit a698f85 into ansible:main Aug 27, 2022
@ssbarnea ssbarnea deleted the fix/more2 branch August 27, 2022 08:23
cognifloyd
cognifloyd reviewed Aug 27, 2022
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed reviewing earlier

src/ansiblelint/rules/name.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd left review comments

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name[casing]: False positive when Chinese task/play names are used
2 participants
@ssbarnea @cognifloyd