Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: empty string compare rule #2400

Merged
merged 2 commits into from Sep 15, 2022
Merged

Docs: empty string compare rule #2400

merged 2 commits into from Sep 15, 2022

Conversation

oraNod
Copy link
Collaborator

@oraNod oraNod commented Sep 8, 2022

Add MD documentation for the empty_string_compare rule.

@ssbarnea
Copy link
Member

@oraNod it is much better to make the change atomic (per rule), even if that means opening 10 pull requests. While I made few fixes on your change I observed that the no-handler docs and change seems wrong and I would like to remove it from this change, but that is not so easy if everything is in a bundle.

@oraNod oraNod force-pushed the lint-rule-md branch 3 times, most recently from b609e0d to 22cf91d Compare September 12, 2022 19:45
@oraNod
Copy link
Collaborator Author

oraNod commented Sep 13, 2022

@ssbarnea Do you want me to break this one into multiple PRs too? Or was it just moving the no_handler rule to a separate PR?

@ssbarnea
Copy link
Member

@oraNod If you can split it it would be awesome as it would make much easier to review, update and merge them one by one.

Some of them would be harder to review and we want to merge the easy ones ASAP.

@oraNod
Copy link
Collaborator Author

oraNod commented Sep 13, 2022

@ssbarnea Sounds good. I'll do that today, just wasn't sure as you mentioned in chat you might just merge this one. Thanks!

@oraNod oraNod changed the title Docs: lint rules part one Docs: empty string compare rule Sep 13, 2022
@ssbarnea ssbarnea merged commit 82042ad into ansible:main Sep 15, 2022
@ssbarnea ssbarnea added the bug label Sep 16, 2022
@oraNod oraNod deleted the lint-rule-md branch October 6, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants